London | 26-ITP-Jan | Raihan Sharif | Sprint 2 | form control#1202
London | 26-ITP-Jan | Raihan Sharif | Sprint 2 | form control#1202RaihanSharif wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
RaihanSharif
added
the
Needs Review
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
-
According to https://validator.w3.org/, there are errors in your code. Can you fix them?
-
Most labels in a HTML form begin with an uppercase letter. Can yo use an AI tool to find out why it is better that way?
| <select | ||
| name="shirt-color" | ||
| id="shirt-color" | ||
| aria-label="select shirt color" | ||
| required> | ||
| <option value="red">red</option> | ||
| <option value="red">green</option> | ||
| <option value="red">blue</option> | ||
| </select> |
There was a problem hiding this comment.
Can you configure the <select> element so that no option is selected by default, and thus allowing the user to make an explicit choice?
Also, the options are not marked up correctly. (Copy-paste error)
cjyuan
added
Reviewed
Select element now does not select one of the values by default. Also chose not to remove trailing / in void elements. As prettier does not allow this. Would require installing and configuring an unmaintained extension.
RaihanSharif
added
the
Needs Review
RaihanSharif
removed
Needs Review
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
1 similar comment
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
2 participants
Learners, PR Template
Self checklist
Changelist
Created form with relevant inputs, validations and accessibility with aria-labels.